Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 public page is active when it's disabled in config #213

Closed
6 of 7 tasks
ElectricPaperInformationssystemeGmbH opened this issue Aug 18, 2023 · 6 comments
Closed
6 of 7 tasks
Assignees
Labels
bug Something isn't working epi-1 EPI-1 project

Comments

@ElectricPaperInformationssystemeGmbH
Copy link

ElectricPaperInformationssystemeGmbH commented Aug 18, 2023

Preflight checklist

  • I could not find a solution in the existing issues, docs, nor discussions.

Current Behavior

Public website is displayed although deactivated in JSON.

Expected Behavior

if deactivated in json, there have to be no way to display the public election page

Steps To Reproduce

No response

Environment

- OS:
- Web browser:

Tasks

Tasks

Master PRs

  1. bug
    Findeton
  2. bug
    Findeton
  3. bug
    Findeton

Stable PRs

  1. bug
    Findeton
  2. bug
    Findeton
  3. bug
    Findeton

Additional context

No response

@edulix
Copy link
Contributor

edulix commented Aug 26, 2023

@Findeton do you have a test election config and link for an election with publicPage=false to test?

@edulix edulix removed the triage needs triage label Aug 26, 2023
@Findeton
Copy link

@Findeton
Copy link

@edulix
Copy link
Contributor

edulix commented Aug 29, 2023

@Findeton can you please create an example with smart link authentication? I wonder what happens in that case, since the login page is not valid per-se as a redirection. I'm talking about what happens when you enter https://felix-dev.sequentech.io/election/34570017/public/home

@Findeton
Copy link

If you go to /public/home for an election with smart link and a disabled home page, it will redirect to the login page. You can try it here:

https://felix-dev.sequentech.io/election/34570025/public/home

It's just that the login page will look disabled. (I can't upload a screenshot because github sucks).

@edulix
Copy link
Contributor

edulix commented Aug 30, 2023

Right now that link goes to "http://sequent/admin" @Findeton

Findeton added a commit to sequentech/admin-console that referenced this issue Aug 31, 2023
Findeton added a commit to sequentech/voting-booth that referenced this issue Aug 31, 2023
Findeton added a commit to sequentech/election-portal that referenced this issue Aug 31, 2023
Findeton added a commit to sequentech/admin-console that referenced this issue Aug 31, 2023
Findeton added a commit to sequentech/voting-booth that referenced this issue Aug 31, 2023
Findeton added a commit to sequentech/election-portal that referenced this issue Aug 31, 2023
Findeton added a commit to sequentech/admin-console that referenced this issue Aug 31, 2023
Findeton added a commit to sequentech/voting-booth that referenced this issue Aug 31, 2023
Findeton added a commit to sequentech/election-portal that referenced this issue Aug 31, 2023
@edulix edulix changed the title 🐞 public page is active 🐞 public page is active when it's disabled in config Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epi-1 EPI-1 project
Projects
None yet
Development

No branches or pull requests

2 participants