Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 smartlink as alternative auth method #221

Closed
3 of 4 tasks
ElectricPaperInformationssystemeGmbH opened this issue Aug 22, 2023 · 3 comments
Closed
3 of 4 tasks
Assignees
Labels
1st-gen bug Something isn't working epi-1 EPI-1 project

Comments

@ElectricPaperInformationssystemeGmbH
Copy link

ElectricPaperInformationssystemeGmbH commented Aug 22, 2023

Preflight checklist

  • I could not find a solution in the existing issues, docs, nor discussions.

Current Behavior

If smartlink is not the main authentication method, the login page is displayed first, then nothing happens. Only when you switch to the smartlink tab will you be authenticated.

Expected Behavior

Smartlink auth method must appear seamless to a voter. Without any user interaction

Steps To Reproduce

https://gist.github.com/ElectricPaperInformationssystemeGmbH/2e5d6abc8bc7f70b2ac9ebb4ef054066

Environment

- OS:
- Web browser:

Tasks

Tasks

Master PRs

  1. bug
    edulix

Stable PRs

  1. bug

Additional context

No response

@ElectricPaperInformationssystemeGmbH ElectricPaperInformationssystemeGmbH added bug Something isn't working epi-1 EPI-1 project triage needs triage labels Aug 22, 2023
@edulix edulix removed the triage needs triage label Apr 15, 2024
@edulix edulix assigned edulix and unassigned Findeton Apr 22, 2024
edulix added a commit to sequentech/common-ui that referenced this issue Apr 22, 2024
@edulix
Copy link
Contributor

edulix commented Apr 22, 2024

@sergiydmukhinepi I've fixed the issue, please review:

@edulix edulix added the 1st-gen label Apr 23, 2024
Findeton pushed a commit to sequentech/common-ui that referenced this issue Apr 23, 2024
Findeton pushed a commit to sequentech/common-ui that referenced this issue Apr 23, 2024
Findeton added a commit to sequentech/common-ui that referenced this issue Apr 23, 2024
Parent issue: sequentech/meta#221

Co-authored-by: Eduardo Robles <edu@sequentech.io>
@sergiydmukhinepi
Copy link

Thank you, it works.

@edulix
Copy link
Contributor

edulix commented Apr 26, 2024

Awesome!

@edulix edulix closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st-gen bug Something isn't working epi-1 EPI-1 project
Projects
None yet
Development

No branches or pull requests

3 participants