Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Voting Booth: Security confirmation checkbox support #224

Closed
13 tasks done
markgrafd opened this issue Aug 28, 2023 · 7 comments
Closed
13 tasks done

✨ Voting Booth: Security confirmation checkbox support #224

markgrafd opened this issue Aug 28, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request epi-1 EPI-1 project
Milestone

Comments

@markgrafd
Copy link

markgrafd commented Aug 28, 2023

Preflight checklist

  • I could not find a solution in the existing issues, docs, nor discussions.

Suggestion

Our customers request a verification under oath or a security confirmation before the ballot can be filled out. The check mark should activate the "Start voting" button.

image

Text: I hereby certify that I have read and understood the instructions for voting, and I affirm to the election administration in lieu of oath that I personally fill out the ballot or that I mark the ballot as an auxiliary person in accordance with the will of the voter.

Suggested Implementation

The addition of the following election level fields:

  • mandatory_acceptance_tos_html containing the basic-html text to be displayed.
  • mandatory_acceptance_tos_html_i18n to support translations of the previous field.

If mandatory_acceptance_tos_html is set, then a checkbox will appear containing the configured text, and the Start votingbutton will be disabled unless that checkbox is checked.

Important: Please note that in this suggested implementation this checkbox is implemented in the javascript client of the voting booth. This means that the fact that the voter clicked in this checkbox is not reflected in any manner to the data received in the backend from the voter.

Implementation details

This is how it looks when set:

image

And when checkbox checked:

image

In mobile:

image

Additionally, the text supports basic html and translations using the mandatory_acceptance_tos_html_i18n parameter.

Tasks

Tasks

Master PRs

  1. enhancement
  2. enhancement
  3. enhancement
  4. enhancement

Stable PRs

  1. enhancement
  2. enhancement
  3. enhancement

Additional context

No response

@markgrafd markgrafd added enhancement New feature or request epi-1 EPI-1 project triage needs triage labels Aug 28, 2023
@edulix edulix self-assigned this Nov 3, 2023
@edulix edulix removed the triage needs triage label Nov 13, 2023
@ElectricPaperInformationssystemeGmbH

Logical check would be ok

edulix added a commit to sequentech/ballot-box that referenced this issue Nov 14, 2023
@edulix edulix changed the title ✨ Security confirmation ✨ Voting Booth: Security confirmation checkbox feature support Nov 14, 2023
@edulix edulix changed the title ✨ Voting Booth: Security confirmation checkbox feature support ✨ Voting Booth: Security confirmation checkbox support Nov 14, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Nov 14, 2023
edulix added a commit to sequentech/documentation that referenced this issue Nov 14, 2023
@edulix
Copy link
Contributor

edulix commented Nov 14, 2023

@ElectricPaperInformationssystemeGmbH please review implementation details and confirm approval or request changes or any other information

@ElectricPaperInformationssystemeGmbH

@edulix strange border is around the check box
image

@ElectricPaperInformationssystemeGmbH

@edulix button mouse hover and click effect (shadow) is there if the check box deactivated
image

@ElectricPaperInformationssystemeGmbH

@edulix one line text not in the middle
image

@edulix
Copy link
Contributor

edulix commented Nov 16, 2023

I've fixed the issues.

This is how the text looks when it's small (one line) and the checkbox is unchecked:
image

This how it looks when the text is multiline and checkbox is checked:
image

This is the highlight and mouse-hover process. Doesn't have a mouse-over shadow when the button is disabled, and when clicked and disabled it highlights the mandatory security checkbox elements (input + text) in red:

Screen.Recording.2023-11-16.at.06.08.05.mov

@ElectricPaperInformationssystemeGmbH

looks good, thank you

edulix added a commit to sequentech/ballot-box that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/ballot-box that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/ballot-box that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/documentation that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/common-ui that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/common-ui that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/common-ui that referenced this issue Nov 17, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Nov 17, 2023
@edulix edulix closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epi-1 EPI-1 project
Projects
None yet
Development

No branches or pull requests

2 participants