Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Bogus UI when loading voting booth without credentials #262

Closed
4 tasks done
ElectricPaperInformationssystemeGmbH opened this issue Sep 28, 2023 · 5 comments
Closed
4 tasks done
Assignees
Labels
bug Something isn't working epi-1 EPI-1 project

Comments

@ElectricPaperInformationssystemeGmbH
Copy link

ElectricPaperInformationssystemeGmbH commented Sep 28, 2023

Preflight checklist

  • I could not find a solution in the existing issues, docs, nor discussions.

Current Behavior

When entering the path /booth/<election-id>/vote without having logged in (without user credentials), errors happen (shown in the debug console) and an invalid and unexpected erroneous UI appears to the voter.
MicrosoftTeams-image (1)

Expected Behavior

A proper error page explaining that no credentials were found should appear to the visitant.

Implemented solution

The error page is now shown instead, and the Go back button goes to the ConfigService.defaultRoute. Here is a screenshot:
image

Steps To Reproduce

No response

Environment

- OS:
- Web browser:

Tasks

Tasks

Master PRs

Stable PRs

  1. bug

Additional context

No response

@ElectricPaperInformationssystemeGmbH ElectricPaperInformationssystemeGmbH added bug Something isn't working triage needs triage epi-1 EPI-1 project labels Sep 28, 2023
@edulix edulix self-assigned this Oct 8, 2023
@edulix
Copy link
Contributor

edulix commented Oct 8, 2023

@ElectricPaperInformationssystemeGmbH I have not been able to replicate this error. Please provide a way to replicate this issue:

  • a minimal election configuration that shows the issue. As minimal as possible, to ensure that the error is related to one of the few features used.
  • detailed steps of how to reproduce it

I tried to:

  • create an election with presentation.extra_options jut being "success_screen__redirect__url": "http://google.es", "disable__public_home": true and the issue didn't happen to me, I was redirected successfully.
  • reproduce the issue using the demo booth of https://vnext.gremienwahlen.de/booth/101/demo-vote (one of the children elections in the screenshot) and I couldn't - when I clicked finish, I was redirected to EPI website successfully.
  • I tried to copy the presentation.extra_options from mentioned election 101 above (which includes other configuration settings than redirect url and disabled public home) in a new election configuration, and also failed to replicate.

@ElectricPaperInformationssystemeGmbH

@edulix
Copy link
Contributor

edulix commented Oct 9, 2023

@ElectricPaperInformationssystemeGmbH thank you very much! that probably should be fixed, but I think it's a different issue: in v10 the demo voting booth is not https://vnext.gremienwahlen.de/booth/100/vote but https://vnext.gremienwahlen.de/booth/100/demo-vote . And with this second link, things seem to work? If the behavior is also failing after after authentication, then please provide a minimal election.json config so we can replicate in our environment.

@ElectricPaperInformationssystemeGmbH

@edulix ok, I think this is the main problem. Sorry about that, I was misinformed.

@edulix
Copy link
Contributor

edulix commented Oct 9, 2023

No worries, you actually detected a bug since it's failing to show a valid error message or redirect anywhere and in the console log there is an exception being thrown which generates that. I'll still fix it :-)

edulix added a commit to sequentech/voting-booth that referenced this issue Oct 9, 2023
@edulix edulix removed the triage needs triage label Oct 9, 2023
@edulix edulix changed the title 馃悶 redirect at the end of voting if public page is disabled 馃悶 Erroneous UI when loading voting booth without credentials Oct 9, 2023
@edulix edulix changed the title 馃悶 Erroneous UI when loading voting booth without credentials 馃悶 Bogus UI when loading voting booth without credentials Oct 9, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Oct 9, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Oct 9, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Oct 9, 2023
@edulix edulix closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epi-1 EPI-1 project
Projects
None yet
Development

No branches or pull requests

1 participant