Missing "status" database filter condition

[ghost]

Hi,

looks like there are some database filters in Notion which are missing in the library. For example, there is no status filter condition inside notion.api.v1.model.databases.query.filter.condition

[seratch]

Hi @lsimunec, thanks for flagging this. If I remember correctly, the filter condition for status properties was not a thing a few weeks ago (I did quick prototyping and it didn't work). Now the feature may be available on the Notion API side. If it's a thing already, I am happy to work on the change when I have time for this project. Contributions are greatly appreciated too

[TWiStErRob]

I was looking to add a value to a property which has Status type and it's not supported. So I guess in general the Status type support is missing @seratch?

Based on https://www.google.com/search?q=status+column+notion the Status property type was added in 2022 June, docs: https://www.notion.so/help/guides/status-property-gives-clarity-on-tasks. But this is a backwards-compatible change, so full support for https://developers.notion.com/changelog/releasing-notion-version-2022-06-28 is not necessary to resolve this.

[TWiStErRob]

An implementation thing to prepare for future similar changes like this:
I was getting an NPE when reading from prop: DatabaseProperty like when (prop.type) (type is non-nullable, but contains null). This is because GSON will deserialize null for enums reflectively when it doesn't find a matching serialized name. This is one of the reasons why we usually shouldn't mix serialization (allows null) and domain level (no nulls) classes. In this library that is not really feasible, so a custom type adapter and an "Unknown" type might help: google/gson#608 (comment)

[TWiStErRob]

Ah accidentally saw you were trying https://github.com/seratch/notion-sdk-jvm/tree/status-prop-wip :)