Update return type in fromHexStringToBytes for Next.js compatibility #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I don’t remember why the buffer method call is necessary, but we need to do thorough tests before merging this change. |
seratch
approved these changes
Apr 18, 2024
|
Thanks again for your contribution! Your change was included in v0.10.10, which I just shipped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #24
Overview
This PR addresses an issue in the
fromHexStringToBytesfunction that was causing errors in Next.js applications. To resolve this, the return type of the function has been changed fromArrayBufferLiketoUint8Array.Changes
fromHexStringToBytesfromArrayBufferLiketoUint8Arrayto ensure compatibility with Next.js.Testing
The function has been tested locally in a Next.js setup and is working as expected. However, tests in environments such as Cloudflare Workers are pending.
Please review the changes and let me know if there are any concerns or additional adjustments needed. Further testing in other environments will be conducted as needed.