New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.8.x #938

Closed

7 of 8 tasks

serbanghita opened this issue Aug 31, 2023 · 4 comments

Assignees

Owner

serbanghita commented Aug 31, 2023 •

edited

Support for PHP>=8.x
PSR-16 cache support https://github.com/php-fig/simple-cache
Run benchmark tests https://github.com/phpbench/phpbench
Establish perf tests baselines
Split regex strings into array of strings
Run before/after per tests
Git hooks: lint and run tests
Implement ReadTheDocs? Example: https://phpbench.readthedocs.io/en/latest/

serbanghita self-assigned this

Owner Author

serbanghita commented Oct 6, 2023

Released https://github.com/serbanghita/Mobile-Detect/releases/tag/4.8.01

serbanghita closed this as completed

acelaya commented Nov 10, 2023

Just out of curiosity. Why did you jump directly to v4.8.x and skipped everything between 4.0.x and 4.7.x?

Owner Author

serbanghita commented Nov 11, 2023

@acelaya I tried to somehow reflect the supported PHP version

2.x - already supported PHP 5.3 so no change there
3.74.x - because it supports PHP 7.4
and lastly
4.8.x - because it supports PHP 8.0

looking in retrospect, this is kind of dumb but I can't go back right now :))

acelaya commented Nov 11, 2023

I see 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment