Omit a layer of unnecessary nesting from Debug impl

serde-rs · May 9, 2020 · 351d847 · 351d847
1 parent baae6d9
commit 351d847
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 15 deletions.
diff --git a/src/value/mod.rs b/src/value/mod.rs
@@ -177,8 +177,16 @@ impl Debug for Value {
             Value::Bool(v) => formatter.debug_tuple("Bool").field(&v).finish(),
             Value::Number(ref v) => Debug::fmt(v, formatter),
             Value::String(ref v) => formatter.debug_tuple("String").field(v).finish(),
-            Value::Array(ref v) => formatter.debug_tuple("Array").field(v).finish(),
-            Value::Object(ref v) => formatter.debug_tuple("Object").field(v).finish(),
+            Value::Array(ref v) => {
+                formatter.write_str("Array(")?;
+                Debug::fmt(v, formatter)?;
+                formatter.write_str(")")
+            }
+            Value::Object(ref v) => {
+                formatter.write_str("Object(")?;
+                Debug::fmt(v, formatter)?;
+                formatter.write_str(")")
+            }
         }
     }
 }

diff --git a/tests/debug.rs b/tests/debug.rs
@@ -50,20 +50,16 @@ fn error() {
     assert_eq!(format!("{:?}", err), expected);
 }
 
-const INDENTED_EXPECTED: &str = r#"Object(
-    {
-        "array": Array(
-            [
-                Number(
-                    0,
-                ),
-                Number(
-                    1,
-                ),
-            ],
+const INDENTED_EXPECTED: &str = r#"Object({
+    "array": Array([
+        Number(
+            0,
         ),
-    },
-)"#;
+        Number(
+            1,
+        ),
+    ]),
+})"#;
 
 #[test]
 fn indented() {