Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pointer_mut #68

Closed
oli-obk opened this issue May 13, 2016 · 1 comment
Closed

add pointer_mut #68

oli-obk opened this issue May 13, 2016 · 1 comment
Labels
enhancement

Comments

@oli-obk
Copy link
Member

oli-obk commented May 13, 2016

It should be possible to add a pointer_mut(&str) method to Value. This would allow to add and modify values. (Maybe even a delete method) I failed to add such a method because of borrow checker.

#41 (comment)
CryptArchy added a commit to CryptArchy/json that referenced this issue Dec 3, 2016
@CryptArchy
Implement issue serde-rs#68 - add pointer_mut
a864c77 
Move `pointer` function for `Value` into `Pointer` trait.
Add `pointer_mut` and `pointer_owned` to `Pointer` trait.
@CryptArchy CryptArchy mentioned this issue Dec 3, 2016
Merged
CryptArchy added a commit to CryptArchy/json that referenced this issue Dec 3, 2016
@CryptArchy
Implement issue serde-rs#68 - add pointer_mut
98e1d20 
Move `pointer` function for `Value` into `Pointer` trait.
Add `pointer_mut` and `pointer_owned` to `Pointer` trait.
CryptArchy added a commit to CryptArchy/json that referenced this issue Dec 5, 2016
@CryptArchy
Implement issue serde-rs#68 - add pointer_mut
df910fd 
Move `pointer` function for `Value` into `Pointer` trait.
Add `pointer_mut` and `pointer_owned` to `Pointer` trait.
CryptArchy added a commit to CryptArchy/json that referenced this issue Dec 5, 2016
@CryptArchy
Implement issue serde-rs#68 - add pointer_mut
bd6f4ff 
Move `pointer` function for `Value` into `Pointer` trait.
Add `pointer_mut` and `pointer_owned` to `Pointer` trait.

Made oli-obk suggested changes
CryptArchy added a commit to CryptArchy/json that referenced this issue Dec 5, 2016
@CryptArchy
Implement issue serde-rs#68 - add pointer_mut
482ba5e 
Move `pointer` function for `Value` into `Pointer` trait.
Add `pointer_mut` and `pointer_owned` to `Pointer` trait.

Made oli-obk suggested changes
CryptArchy added a commit to CryptArchy/json that referenced this issue Dec 5, 2016
@CryptArchy
Implement issue serde-rs#68 - add pointer_mut
70cfea6 
Move `pointer` function for `Value` into `Pointer` trait.
Add `pointer_mut` and `pointer_owned` to `Pointer` trait.

Made oli-obk suggested changes
CryptArchy added a commit to CryptArchy/json that referenced this issue Dec 6, 2016
@CryptArchy
Implement issue serde-rs#68 - add pointer_mut
a32de27 
Move `pointer` function for `Value` into `Pointer` trait.
Add `pointer_mut` and `pointer_owned` to `Pointer` trait.

Made oli-obk suggested changes
oli-obk added a commit that referenced this issue Dec 6, 2016
@oli-obk
Merge pull request #171 from CryptArchy/pointer_mut
4d6d96a 
Implement issue #68 - add pointer_mut
@dtolnay
Copy link
Member

dtolnay commented Dec 7, 2016

Added in #171 and released in 0.8.4.

@dtolnay dtolnay closed this as completed Dec 7, 2016
CryptArchy added a commit to CryptArchy/json that referenced this issue Dec 8, 2016
@CryptArchy
Implement issue serde-rs#68 - add pointer_mut
be6b295 
Move `pointer` function for `Value` into `Pointer` trait.
Add `pointer_mut` and `pointer_owned` to `Pointer` trait.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @dtolnay