error: cyclic package dependency: package serde_json v0.7.3 depends on itself

[alexreg]

This occurs only when I include the preserve_order feature.

serde_json = { version = "0.7", features = ["preserve_order"] }

[dtolnay]

This is caused by linked-hash-map using serde_json for their tests. Cargo does not yet support optional dev-dependencies (rust-lang/cargo#1596) so they declare a regular dependency - which is circular.

I have a PR serde-rs/serde#412 that will add an alternative way for them to test the serde impls without depending on serde_json.

Once that merges, I will make a linked-hash-map PR of https://github.com/dtolnay/linked-hash-map/commit/dabca618762ed31b50bfa5ea92b5bbfc305d57c5 to remove the serde_json dependency.

[dtolnay]

• merge Move Token De/Serializer to serde_test crate serde#412
• publish serde_test crate
• make a linked-hash-map PR (EDIT: Switch to serde_test and drop dependency on serde_json contain-rs/linked-hash-map#60)
• merge that PR
• release linked-hash-map
• bump serde_json's linked-hash-map dependency
• publish serde_json

[alexreg]

Okay, that would be great. Let me know when it’s done, if you could. Thanks.

On 29 Jun 2016, at 08:24, David Tolnay notifications@github.com wrote:

This is caused by linked-hash-map https://github.com/contain-rs/linked-hash-map using serde_json for their tests. Cargo does not yet support optional dev-dependencies (rust-lang/cargo#1596 rust-lang/cargo#1596) so they declare a regular dependency - which is circular.

I have a PR serde-rs/serde#412 serde-rs/serde#412 that will add an alternative way for them to test the serde impls without depending on serde_json.

Once that merges, I will make a linked-hash-map PR of dtolnay/linked-hash-map@dabca61 https://github.com/dtolnay/linked-hash-map/commit/dabca618762ed31b50bfa5ea92b5bbfc305d57c5 to remove the serde_json dependency.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #91 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAEF3N9oWbzRAy71AdVX_Z0Gd_kz_058ks5qQh2YgaJpZM4JArs0.

[alexreg]

It looks like the PR has already been merged, just not closed yet?

[dtolnay]

The first one has merged. I am marking off the steps in my previous comment as they happen.

[dtolnay]

@alexreg I just published v0.7.4 with a fix.

[alexreg]

@dtolnay Thanks!

On 30 Jun 2016, at 03:16, David Tolnay notifications@github.com wrote:

@alexreg https://github.com/alexreg I just published v0.7.4 with a fix.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #91 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAEF3IKj1mIT539LeJCCzy51WnY7BC-dks5qQycKgaJpZM4JArs0.