add preserve_order feature #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would strongly prefer to use |
|
OK. If you like I can update this when it's ready. |
|
contain-rs/linked-hash-map#54 has finally been merged, now waiting on contain-rs/linked-hash-map#57. |
|
That one merged too, waiting on a release contain-rs/linked-hash-map#56. |
| @@ -824,8 +856,8 @@ impl de::Deserializer for Deserializer { | |||
| Some(_) => Err(de::Error::invalid_type(de::Type::Map)), | |||
| None => visitor.visit(VariantDeserializer { | |||
| de: self, | |||
| val: Some(value), | |||
| variant: Some(Value::String(variant)), | |||
| val: Some(value.clone()), | |||
There was a problem hiding this comment.
These clones are no longer required.
This was referenced Jun 24, 2016
|
I released v0.7.2 with this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a PR for #54
linked-hash-map needs to be released (probably version = "0.0.11") before this can be merged.
I had to use
linked_hash_map::Iter<'a, String, Value>as a replacement forbtree_map::IntoIter<String, Value>. This in turn required me to clone keys/values indeserialize_enumandvisit_key. I'm not sure this is the best solution.Also since I'm new to Rust and this is my very first PR please check my code thoroughly :)