Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating RawValues from references to unsized values #841

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Allow creating RawValues from references to unsized values #841

merged 1 commit into from
Jan 1, 2022

Conversation

EFanZh
Copy link
Contributor

@EFanZh EFanZh commented Jan 1, 2022 •
edited
Loading

Currently, we cannot creating RawValue from &str using serde_json::value::to_raw_value since the function requires Sized implicitly. This PR removes this restriction.

dtolnay
dtolnay approved these changes Jan 1, 2022
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 6de3d39 into serde-rs:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EFanZh @dtolnay