Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document #[serde(tag)] on struct structs #103

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Dec 15, 2019

@jplatte
Copy link
Contributor Author

jplatte commented Jun 16, 2020

ping @dtolnay

@zeenix
Copy link

zeenix commented Aug 5, 2020

@dtolnay ping or in general. I'd suggest just merging it cause it's trivial and having this docs is better than not having it so we don't need to be picky.

@magurotuna
Copy link

This is exactly what I was looking for. If this had been documented it would have saved my time a lot.
@dtolnay I'd be more than happy if this PR got merged and published. Do you see any issues in this PR that prevent you from merging it?

@jplatte
Copy link
Contributor Author

jplatte commented Dec 17, 2021

Hey @dtolnay, could you please take a look?

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 8e61f21 into serde-rs:master Jul 9, 2023
@jplatte jplatte deleted the struct_tag branch July 10, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

#[serde(tag=...)] attribute not rejected on structs
4 participants