Move deny(clippy) to command line arguments in the CI job

serde-rs · Nov 5, 2021 · 8f16ac0 · 8f16ac0
1 parent 737f78c
commit 8f16ac0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -155,9 +155,9 @@ jobs:
       - uses: dtolnay/rust-toolchain@clippy
         # The need for -Aredundant_field_names here is a Clippy bug.
         # https://github.com/rust-lang/rust-clippy/issues/5356
-      - run: cd serde && cargo clippy --features rc,unstable -- -D clippy::all -A clippy::redundant_field_names
-      - run: cd serde_derive && cargo clippy -- -D clippy::all
-      - run: cd serde_derive_internals && cargo clippy -- -D clippy::all
-      - run: cd serde_test && cargo clippy -- -D clippy::all -A clippy::redundant_field_names
-      - run: cd test_suite && cargo clippy --tests --features unstable -- -D clippy::all -A clippy::redundant_field_names
-      - run: cd test_suite/no_std && cargo clippy -- -D clippy::all -A clippy::redundant_field_names
+      - run: cd serde && cargo clippy --features rc,unstable -- -Dclippy::all -Dclippy::pedantic -Aclippy::redundant_field_names
+      - run: cd serde_derive && cargo clippy -- -Dclippy::all -Dclippy::pedantic
+      - run: cd serde_derive_internals && cargo clippy -- -Dclippy::all -Dclippy::pedantic
+      - run: cd serde_test && cargo clippy -- -Dclippy::all -Dclippy::pedantic -Aclippy::redundant_field_names
+      - run: cd test_suite && cargo clippy --tests --features unstable -- -Dclippy::all -Aclippy::redundant_field_names
+      - run: cd test_suite/no_std && cargo clippy -- -Dclippy::all -Aclippy::redundant_field_names
diff --git a/serde/src/lib.rs b/serde/src/lib.rs
@@ -94,7 +94,6 @@
 #![cfg_attr(feature = "unstable", feature(never_type))]
 #![allow(unknown_lints, bare_trait_objects, deprecated)]
 #![cfg_attr(feature = "cargo-clippy", allow(renamed_and_removed_lints))]
-#![cfg_attr(feature = "cargo-clippy", deny(clippy, clippy_pedantic))]
 // Ignored clippy and clippy_pedantic lints
 #![cfg_attr(
     feature = "cargo-clippy",

diff --git a/serde_derive/src/lib.rs b/serde_derive/src/lib.rs
@@ -15,7 +15,6 @@
 
 #![doc(html_root_url = "https://docs.rs/serde_derive/1.0.130")]
 #![allow(unknown_lints, bare_trait_objects)]
-#![deny(clippy::all, clippy::pedantic)]
 // Ignored clippy lints
 #![allow(
     // clippy false positive: https://github.com/rust-lang/rust-clippy/issues/7054

diff --git a/serde_derive_internals/lib.rs b/serde_derive_internals/lib.rs
@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/serde_derive_internals/0.26.0")]
 #![allow(unknown_lints, bare_trait_objects)]
-#![deny(clippy::all, clippy::pedantic)]
 // Ignored clippy lints
 #![allow(
     clippy::cognitive_complexity,

diff --git a/serde_test/src/lib.rs b/serde_test/src/lib.rs
@@ -146,7 +146,6 @@
 
 #![doc(html_root_url = "https://docs.rs/serde_test/1.0.130")]
 #![cfg_attr(feature = "cargo-clippy", allow(renamed_and_removed_lints))]
-#![cfg_attr(feature = "cargo-clippy", deny(clippy, clippy_pedantic))]
 // Ignored clippy lints
 #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, needless_doctest_main))]
 // Ignored clippy_pedantic lints