Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The derive feature should be stricter in its dependency specification #1647

Closed
mathstuf opened this issue Oct 14, 2019 · 0 comments · Fixed by #1664
Closed

The derive feature should be stricter in its dependency specification #1647

mathstuf opened this issue Oct 14, 2019 · 0 comments · Fixed by #1664

Comments

@mathstuf
Copy link
Contributor

With -Z minimal-versions becoming a thing and me trying to get it to work for my crates, I've been running into issues. One is that serde's derive feature just requires "1.0". This easily ends up being 1.0.0 in such builds and is generally not supportive of all the attributes usable in newer serde versions. This version specification should be stricter.

I don't know if it'd be easy to test in this crate directly because I suspect the versions are always going to be unified and end up using the serde_derive sitting right beside it instead of some theoretical minimum.

The first step would be to find the oldest version of serde_derive which supports all the features documented in the serde crate and which generates code which works for that version of serde.

Or just punt and require that the versions of serde_derive == serde one way or another.

If this ends up coming to any conclusion about the overall interaction this use case and the proposed feature, we should report it to the cargo tracking issue: rust-lang/cargo#5657

mathstuf added a commit to mathstuf/serde that referenced this issue Nov 1, 2019
This ensures that all features supported by serde are always available
through the derive macro provided through the feature flag.

Fixes: serde-rs#1647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant