implement (de)serialize_with for variants #1015
Conversation
test_suite/tests/test_annotations.rs
Outdated
| #[serde(serialize_with="serialize_some_other_variant")] | ||
| Struct { | ||
| f1: String, | ||
| #[serde(skip_serializing_if="is_zero")] |
There was a problem hiding this comment.
I would prefer not to support skip attributes inside of a variant with serialize_with until somebody has a compelling use case for it. For now the derive should panic so it fails to compile. I feel like it is just as convenient and more obvious for this logic to be encompassed inside the serialize_with function:
fn serialize_some_other_variant<S>(f1: &String,
f2: &u8,
serializer: S)
-> Result<S::Ok, S::Error>
where S: Serializer
{
if is_zero(*f2) {
/* ... */
} else {
/* ... */
}
}There was a problem hiding this comment.
Sure, I'll rip that part out. I was split on this and ended up erring on the side of compatibility with existing features.
As discussed in serde-rs#1013, serialize_with functions attached to variants receive an argument for each inner value contained within the variant. Internally such a function is wired up to the serializer as if the variant were a newtype variant.
Complements variant serialize_with and closes serde-rs#1013.
spinda
changed the title
|
@dtolnay That should wrap up the implementation (no longer WIP). |
|
The clippy thing is unfortunate. @dtolnay do you think it would make sense to allow derefs in |
|
We already allow derefs in serialize_with and deserialize_with. That is why #631 (comment) works, for example. The tests added in this PR can be changed as clippy says: use &str instead of &String. The generated code is doing the equivalent of this, which works: struct __SerializeWith<'__a> {
values: (&'__a String, &'__a u8),
}
fn main() {
let sw = __SerializeWith { values: (&"".to_owned(), &0) };
serialize_some_other_variant(sw.values.0, sw.values.1);
}
fn serialize_some_other_variant(_: &str, _: &u8) {} |
|
Oh, so you can. I didn't realize that. I've pushed a fix. |
Work in progress for #1013. So far I've implemented the
serialize_withhalf. Any early feedback would be appreciated.