Complete support for formats treating nulls as None
#1685
Conversation
…-tagged enums for formats that treat unit as `None`
|
Please feel free to squash the commits into the first one, my whack-a-mole approach to updating the tests doesn't contain any interesting information. |
|
@dtolnay Can you please take a look at this? Thanks! |
|
@dtolnay Sorry to bother again, but is there some progress around this PR? |
|
Hey @dtolnay I noticed there was a new release a couple days ago… could you please look at this? |
There was a problem hiding this comment.
This is a high risk–low benefit change so I have not been able to prioritize reviewing it.
This breaks support for formats that distinguish units and options and do not treat them as equivalent. I understand that your format considers them the same thing by treating null as visit_none in the deserializer, but it's not clear to me that one behavior is necessarily universally better than the other to be worth breaking one in favor of the other.
|
Ah, alright – I understand that, thanks. |
This is a follow-up to my previous PR about being able to treat
nullasNone. I've noticed a couple more cases where an internally-taggedenumwith a struct variant containing()wasn't able to be deserialized. This PR amends them.