Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 128-bit integers on emscripten post Rust 1.40 #2076

Merged
merged 1 commit into from Aug 21, 2021

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented Aug 21, 2021

rust-lang/rust#65251 fixed the issue where Rust was unable to support 128-bit integers on emscripten targets, that has been in Rust since 1.40 (looking at the tags on rust-lang/rust@2bf59be)

Fixes #1995, supersedes #2049

@Manishearth Manishearth changed the title Rust supports i128/u128 on emscripten post Rust 1.40 Enable 128-bit integers on emscripten post Rust 1.40 Aug 21, 2021
@oli-obk oli-obk merged commit 990f7eb into serde-rs:master Aug 21, 2021
19 checks passed
@Manishearth Manishearth deleted the emscripten-i128 branch Aug 21, 2021
@Manishearth
Copy link
Contributor Author

Manishearth commented Aug 21, 2021

Thanks! @dtolnay would it be possible to get a point release for this? In practice most of the ecosystem does not pref-gate Serializer/Deserializer impls on emscripten; so the status quo is effectively that programs that use serde just don't compile on emscripten; I'd like to get that fixed.

@dtolnay
Copy link
Member

dtolnay commented Aug 21, 2021

Published in 1.0.128.

@Manishearth
Copy link
Contributor Author

Manishearth commented Aug 21, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants