Field with deserialize_with should not implement Deserialize #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #259.
The solution is, if a field is missing:
skip_deserializing
).Visitor::Error::missing_field(name)
.visitor.missing_field(name)
to possibly handle the field.This means
deserialize_with
no longer goes through the visitor'smissing_field
, instead failing directly unless there is a default. Thus fields withdeserialize_with
do not require Deserialize as a bound. The missing field behavior can be controlled by setting a default for the field.