Attribute for handwritten where clauses #352
Conversation
|
I failed a handful of clippy lints, working on them now. |
|
FYI, clippy 0.0.72 was just published, fixing the false positives in this PR 😄 |
| @@ -2,6 +2,7 @@ | |||
| #![cfg_attr(feature = "nightly-testing", feature(plugin))] | |||
| #![cfg_attr(feature = "nightly-testing", allow(too_many_arguments))] | |||
| #![cfg_attr(feature = "nightly-testing", allow(used_underscore_binding))] | |||
| #![cfg_attr(feature = "nightly-testing", allow(useless_let_if_seq))] | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Should be fixed in Clippy 0.0.73 just published. Thanks again for the report.
There was a problem hiding this comment.
Thanks Martin, that solved it.
This reverts commit 4e6cd2d.
| fields.iter() | ||
| .enumerate() | ||
| .map(|(i, field)| { | ||
| let attrs = try!(FieldAttrs::from_field(cx, i, field)); | ||
| Ok((field, attrs)) | ||
| Ok((field.clone(), attrs)) |
There was a problem hiding this comment.
why was this changed from a reference to a value?
There was a problem hiding this comment.
Because in all_fields_with_attrs the Vec<ast::StructField> does not live long enough to return references into it.
|
Implementation lgtm. Design wise I think it's good, too. We can always add more magic later if it seems helpful/necessary, but the current version gives the user a lot of control to fix whatever issues they have with codegen. Discovering this feature is hard though... But I'm not sure what to do about it... It would be great if we had some attribute to attach to generated ast-nodes that would cause rustc to emit some custom link/info if an error occurs inside that generated node. Let's see how often people complain, and adding a bound is the solution. @homu r+ |
Attribute for handwritten where clauses Addresses (2) and (3) in #336 (comment). - If there is a `#[serde(bound="...")]` attribute on the type, use the union of that and the actual type's `where` clause as the `where` clause for the impl and do not attempt to generate any additional `where` clauses whatsoever. - If there is a `#[serde(bound="...")]` attribute on a field, use that and do not attempt to generate any additional `where` clauses for the field. The `bound` attribute behaves similar to `rename` in that you can specify a single attribute that applies to both ser and de, or individual ones. ``` #[serde(bound="D: Serialize + Deserialize")] #[serde(bound(serialize="D: Serialize", deserialize="D: Deserialize"))] ``` EDIT: now addresses (4) from #336 (comment) as well. - If a field contains direct recursion, do not generate any bounds based on that field except from `bound` attributes.
|
Thanks! It would be great to bump and publish a version |
|
Thanks! |
Addresses (2) and (3) in #336 (comment).
#[serde(bound="...")]attribute on the type, use the union of that and the actual type'swhereclause as thewhereclause for the impl and do not attempt to generate any additionalwhereclauses whatsoever.#[serde(bound="...")]attribute on a field, use that and do not attempt to generate any additionalwhereclauses for the field.The
boundattribute behaves similar torenamein that you can specify a single attribute that applies to both ser and de, or individual ones.EDIT: now addresses (4) from #336 (comment) as well.
boundattributes.