Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Display for de::Type #426

Merged
merged 1 commit into from
Jul 7, 2016
Merged

impl Display for de::Type #426

merged 1 commit into from
Jul 7, 2016

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jul 7, 2016

Fixes #425.

@oli-obk
Copy link
Member

oli-obk commented Jul 7, 2016

You could also implement the debug impl to forward to the display impl, but if you think that's not helpful, this PR lgtm.

@dtolnay
Copy link
Member Author

dtolnay commented Jul 7, 2016

I subscribe to this philosophy from the docs:

Generally speaking, you should just derive a Debug implementation.

@dtolnay dtolnay merged commit 67d86dc into master Jul 7, 2016
@dtolnay dtolnay deleted the display branch July 7, 2016 07:59
@dtolnay dtolnay mentioned this pull request Jul 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtolnay @oli-obk