Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3 support? #88

Closed
hirokai opened this issue Sep 21, 2020 · 5 comments
Closed

Vue3 support? #88

hirokai opened this issue Sep 21, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@hirokai
Copy link

hirokai commented Sep 21, 2020

Is there any plan to support Vue3? If any, APIs have changed significantly in Vue3, and I wonder how simultaneous support for both Vue 2 and 3 will be realized.

I may want to contribute if possible.

@serebrov
Copy link
Owner

I am interested indeed in adding a Vue 3 support, either as a universal library or by making a separate Vue 3 package. I know it has been released, but it is still an early stage and they promised to also port some V3 features back to V2 and also release a "migration build" which will be more backward compatible (not sure though if it is good to rely on it for a component, as the target application may not use the migration build).

Anyway, I haven't study this deeply, it might actually be not that complex to support both Vue versions, as while working on my version of emoji mart, I extracted most of the logic out of components, so they are a relatively thin layer on top of Vue-independent code (the EmojiIndex and EmojiView classes).

@serebrov serebrov added the enhancement New feature or request label Oct 4, 2020
serebrov added a commit that referenced this issue Jan 30, 2021
@serebrov
Copy link
Owner

After initial testing, there was a small issue in Vue 3, which is fixed and now the Picker component works in the Vue 3 app without major changes. Published version 8.0.1 with a fix.

I also added a demo app with Vue 3 here.

Not closing this issue yet for the case other problems are found.

@Skye-31
Copy link

Skye-31 commented Jan 31, 2021

Not closing this issue yet for the case other problems are found.

Hi there. It appears I've found one. I'm currently using Vue 2 with Nuxt.js, and attempting to use version 8.0.1 causes the following errors to occur whenever I attempt to scroll within the component, or click one of the tabs at the top. As a note, I do use some custom emojis so that may affect it. Contact me if I can provide you with any other information!

image

@serebrov
Copy link
Owner

@Alex-R-31 Thanks for reporting it! I've just published version 8.0.3 with a fix. Can you check if it works for you?

@Skye-31
Copy link

Skye-31 commented Jan 31, 2021

@serebrov that's fixed it! Thanks for the speedy response.

@serebrov serebrov closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants