feat: Update to Emoji 15 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serebrov
requested changes
Jun 1, 2023
There was a problem hiding this comment.
Thanks for the PR! Please check my question.
Also, some tests are failing, but that is expected - emojis changed positions and we need to update test snapshots, as described here, please run npm run jest -- -u to update snapshots.
I changed the base for this PR to a branch instead of master, so I can test it more after merge before pushing to master.
| @@ -281,7 +281,7 @@ export default { | |||
| let emoji = index.findEmoji(':smile:') | |||
| // Note, that position in the emoji sheet is calculated by | |||
| // `emoji` object | |||
| let style = `background-position: ${emoji.getPosition()}; background-image: url(https://unpkg.com/emoji-datasource-twitter@14.0.0/img/twitter/sheets-256/64.png); width: 24px; height: 24px; display: inline-block; background-size: 5700%` | |||
| let style = `background-position: ${emoji.getPosition()}; background-image: url(https://unpkg.com/emoji-datasource-apple@15.0.0/img/apple/sheets-256/64.png); width: 24px; height: 24px; display: inline-block; background-size: 5700%` | |||
There was a problem hiding this comment.
❓ Is the twitter -> apple change functional (something did not work) or just visual (apple looks better?)?
There was a problem hiding this comment.
I can revert this, mostly this was from a different change (twitter emojis are discontinued and do not provide Emoji 15).
Also adjusted the tests for the new emoji tiles Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the emoji data to version 15.