Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect method params #3

Merged
merged 2 commits into from
Mar 20, 2018
Merged

incorrect method params #3

merged 2 commits into from
Mar 20, 2018

Conversation

wrossier
Copy link
Contributor

param sent to getAll method need to be an array not a string

@wrossier
incorrect method params
afbc4bd 
param sent to getAll method need to be an array not a string
@seregazhuk seregazhuk self-requested a review March 20, 2018 15:21
@seregazhuk seregazhuk added the bug label Mar 20, 2018
seregazhuk
seregazhuk requested changes Mar 20, 2018
View reviewed changes
Copy link
Owner

@seregazhuk seregazhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! 👍 Since now everything the code does - is calling the parent method, we can now simply delete it. Can you update a PR and just delete this method?

@wrossier
Update Cards.php
22cf429 
method getAll useless here
@wrossier
Copy link
Contributor Author

done

@seregazhuk seregazhuk merged commit 3889303 into seregazhuk:master Mar 20, 2018
@seregazhuk
Copy link
Owner

Merged. Use release 0.2.2, it contains this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seregazhuk seregazhuk seregazhuk requested changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wrossier @seregazhuk