Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in electron app when loading model #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dsouza95
Copy link

@dsouza95 dsouza95 commented Jan 9, 2023

This PR fixes crashes in electron applications that use asar archiving (as seen in #30), which is enabled by default in electron.
When using asar archiving, native dependencies such as speech-recorder are not bundled in the asar file, remaining in the separate path app.asar.unpacked.

As seen in this issue, Electron has trouble using __dirname, as the asar bundling messes with the paths for dependencies: __dirname will resolve to a path with app.asar in it, while it should actually have app.asar.unpacked. For now, there is no fix or API for handling this on electron, so this simple replace should address the problem (which is the approach taken in the issue above).

@tmacwill
Copy link
Member

thanks for tracking this down and opening a PR! I'd be hesitant to do a blanket replace on the model path, since there might be cases where a user doesn't want that. what do you think about adding an optional argument to the options object called something like asar or electron that's false by default, and then only doing this replace if that argument is set?

@dsouza95
Copy link
Author

Sure thing, sounds much better. Will update the PR right away!

@TheJakey
Copy link

TheJakey commented May 1, 2023

Hello guys, any info on why is this still open? Looks ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants