Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #34 index -> count #36

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Fix #34 index -> count #36

merged 2 commits into from
Dec 23, 2023

Conversation

JannisBush
Copy link
Contributor

index is now called count at this position. Probably due to pandas 2.0.

@JannisBush JannisBush mentioned this pull request Nov 23, 2023
Closed
@serengil
Copy link
Owner

then, this is going to be broken in older versions. should not we check the version and take an action?

@JannisBush
Copy link
Contributor Author

Yes. That would break old versions of pandas.
I would change the requirements here (https://github.com/serengil/chefboost/blob/master/setup.py#L22) <2 for 0.0.18 without this change and then release a new version 0.0.19 >2 with this change.
(I have not tested the exact versions for theses changes)

@serengil serengil merged commit dedfb28 into serengil:master Dec 23, 2023
@serengil serengil mentioned this pull request Dec 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JannisBush @serengil