Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find match from dataset continuosly try to add unrecognized images to pickle #1030

Closed
AndreaLanfranchi opened this issue Feb 21, 2024 · 6 comments · Fixed by #1031
Closed
Labels
question Further information is requested

Comments

@AndreaLanfranchi
Copy link
Contributor

Just cloned and set up the project locally (Windows 11)
Run python .\stream_py from tests directory and pickle file representations_vgg_face.pkl get built.

image

For whatever reason the image file img39.jpg doesn't get any representation hence not added to the pickle file.
As a result the following log line keeps popping

24-02-21 18:28:25 - ⚠️ Items ['dataset\\img39.jpg'] were added into dataset just after data source dataset\representations_vgg_face.pkl created!

Which is actually not true.
IMO for every processed file would be worth adding a reference into the pickle file with null representation and all values to zero.

@serengil serengil added the question Further information is requested label Feb 21, 2024
@serengil
Copy link
Owner

This is not an issue. It finds that file is missing file in the pickle, but cannot find its embeddings then. That is why, that warning is printed every run.

You should discard that message, it is just warning.

@serengil serengil closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@serengil
Copy link
Owner

You can also delete that image if you do not want to see in the logs.

@AndreaLanfranchi
Copy link
Contributor Author

Thank you for the quick reply.
Probably the workaround of deleting the unrecognized file is ok even if I'm not sure other models can properly detect the face.
Besides leaving the file in place extends the detection phase as on every loop it tries to add the missing file again.
I can try a PR to solve this if you don't mind.

@serengil
Copy link
Owner

Leave it to me, I am currently working on a PR and it may cause conflicts

@AndreaLanfranchi
Copy link
Contributor Author

Sorry ... opened a PR.
Feel free to discard or to cherry pick.

@serengil
Copy link
Owner

Will be happy to merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
2 participants