Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify find data initialization #1032

Merged
merged 5 commits into from Feb 22, 2024
Merged

Simplify find data initialization #1032

merged 5 commits into from Feb 22, 2024

Conversation

AndreaLanfranchi
Copy link
Contributor

This simplifies the cyclomatic complexit of data initialization in find function.

  • Ensures a pickle file always exists (although might be empty)
  • Removes two if branches and duplicated code
  • Early bailout if no representations

Thank you for your patience and attention.

@serengil
Copy link
Owner

LGTM

@serengil serengil merged commit af73d3d into serengil:master Feb 22, 2024
2 checks passed
@AndreaLanfranchi AndreaLanfranchi deleted the al20240222-find-simpler branch February 22, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serengil serengil serengil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndreaLanfranchi @serengil