fix: updated report generation to use temp files with random names

serenity-bdd · Feb 29, 2016 · fa25694 · fa25694
1 parent 5afea72
commit fa25694
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/serenity-core/src/main/java/net/thucydides/core/reports/junit/JUnitXMLOutcomeReporter.java b/serenity-core/src/main/java/net/thucydides/core/reports/junit/JUnitXMLOutcomeReporter.java
@@ -52,7 +52,7 @@ public void generateReportsFor(TestOutcomes testOutcomes) throws IOException {
             File temporary = new File(getOutputDirectory(), reportFilename.concat(unique));
             LOGGER.debug("GENERATING JUNIT REPORT {} using temporary file {}", reportFilename, temporary);
 
-            try(OutputStream outputStream = new BufferedOutputStream(new FileOutputStream(report))){
+            try(OutputStream outputStream = new BufferedOutputStream(new FileOutputStream(temporary))){
                 junitXMLConverter.write(testCase, testCaseOutcomes, outputStream);
                 outputStream.flush();
                 Files.move(temporary.toPath(), report.toPath(), StandardCopyOption.REPLACE_EXISTING);

diff --git a/serenity-core/src/main/java/net/thucydides/core/reports/xml/XMLTestOutcomeReporter.java b/serenity-core/src/main/java/net/thucydides/core/reports/xml/XMLTestOutcomeReporter.java
@@ -79,7 +79,7 @@ public File generateReportFor(final TestOutcome testOutcome, final TestOutcomes
         LOGGER.debug("Generating XML report for {} to file {} (using temp file {})", testOutcome.getTitle(), report.getAbsolutePath(), temporary.getAbsolutePath());
 
         try(
-           OutputStream outputStream = new FileOutputStream(report);
+           OutputStream outputStream = new FileOutputStream(temporary);
            OutputStreamWriter writer = new OutputStreamWriter(outputStream, StandardCharsets.UTF_8)) {
            xstream.toXML(storedTestOutcome, writer);
            writer.flush();