Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots appearing in report on failures even when disabled in serenity properties #2926

Closed
derekjmoo opened this issue Sep 16, 2022 · 6 comments

Comments

@derekjmoo
Copy link

Screenshots are still appearing in the report for failures even when they are disabled in the serenity properties file

serenity.properties file>
serenity.take.screenshots=DISABLED

This is occuring on versions 3.3.0 and above

This also has implications for the workaround for the issue below
#2878

@wakaleo
Copy link
Member

wakaleo commented Oct 22, 2022

Should be fixed in the next release

@wakaleo wakaleo closed this as completed Oct 22, 2022
@suadhika
Copy link

suadhika commented Jan 5, 2023

Any update on this ticket? Which release should fix this issue?

@wakaleo
Copy link
Member

wakaleo commented Jan 5, 2023

It was fixed a while back - just use the latest release.

@suadhika
Copy link

No, I still get the same error with 3.4.3 and above.

@wakaleo
Copy link
Member

wakaleo commented Apr 13, 2023

The latest version is 3.6.23 - have you tried with that version?

@suadhika
Copy link

Ok I haven’t tried 3.6.23 and with 3.4.3 also I am not getting the screenshot. My question itself was wrong. But by disabling the screenshots I wanted the report in Jenkins when tests fail ,which is supposed to be the workaround for #2878 . So this one (#2926) is fine. Probably I should comment on #2878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants