Serenity is not able to work with Iframes anymore

[ricardorlg-yml]

due to this line, if a switch to frame happens, the driver will switch again to current window, making impossible to follow a complete flow over an iframe, this is because when Serenity takes the screenshot, it tries to switch to the active window again, which removes the previous Iframe switch.

serenity-core/serenity-core/src/main/java/net/serenitybdd/core/photography/WebDriverPhotoLens.java

Line 53 in b6481cb

driver.switchTo().window(currentWindow);

Can we make the alertIsDisplayedFor method optional?

[wakaleo]

We can't make alertIsDisplayedFor() optional, as we never know when an alert will be present. However you could propose a change to check whether you are in an iframe and switch to that instead.

[ricardorlg]

for now, the only solution was to allow the task screenshots only on failures. I'm not sure if there is an easy way to know if we came from an Iframe, maybe I will just add a property to disable the verification manually, so is the user's decision to disable the Alert verification.