Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon is outdated #890

Closed
scormaq opened this issue Aug 18, 2017 · 3 comments
Closed

Favicon is outdated #890

scormaq opened this issue Aug 18, 2017 · 3 comments
Labels
good first issue help wanted

Comments

@scormaq
Copy link
Contributor

scormaq commented Aug 18, 2017

Serenity got new nice logo, but favicon was not updated - is it intended? Serenity version 1.5.4-rc.2

screen
@wakaleo
Copy link
Member

wakaleo commented Aug 21, 2017

Fixed in 1.5.4, thanks for pointing this out.

@wakaleo wakaleo closed this as completed Aug 21, 2017
@scormaq
Copy link
Contributor Author

scormaq commented Sep 27, 2017

Hi @wakaleo ,
seems in latest Serenity (1.6.0) favicon not displayed at all (Windows 10, Firefox 52.3.0). Also, highlighted serenity version is wrong (right bottom corner - see screen attached)
screen

@wakaleo wakaleo reopened this Sep 27, 2017
@wakaleo
Copy link
Member

wakaleo commented Sep 27, 2017 •
edited

Had a quick look, but can't get the favicons appearing locally. Happy to accept PRs on this if you know how it should be done - the code in question is https://github.com/serenity-bdd/serenity-core/blob/master/serenity-report-resources/src/main/resources/freemarker/libraries/favicon.ftl

@manisha-A manisha-A mentioned this issue Jul 10, 2018
Merged
wakaleo added a commit that referenced this issue Jul 10, 2018
@wakaleo
Merge pull request #1299 from manisha-A/fix_issue_890_favicon_not_shown
f4bf88d 
Fix report (index.html) Favicon for #890
@wakaleo wakaleo closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wakaleo @scormaq