Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider annotations on non-public test methods (TestAnnotations) #2306

Merged
merged 1 commit into from Dec 3, 2020
Merged

Consider annotations on non-public test methods (TestAnnotations) #2306

merged 1 commit into from Dec 3, 2020

Conversation

fabianlinz
Copy link
Contributor

  • use MethodFinder to lookup method in test class  (e.g. to find non public Junit5 @test method with @title and @WithTag)
  • alternative could be to move the decision which methods to consider to the JUnitStrategy

@fabianlinz
Consider annotations on non-public test methods (TestAnnotations.getM…
6dd81df 
…ethodCalled)

* use MethodFinder to lookup method in test class  (e.g. to find non public Junit5 @test method with @title and @WithTag)
* alternative could be to move the decision which methods to consider to the `JUnitStrategy`
@fabianlinz fabianlinz mentioned this pull request Nov 22, 2020
Closed
@wakaleo wakaleo merged commit ac27922 into serenity-bdd:master Dec 3, 2020
@fabianlinz fabianlinz deleted the consider_annotation_on_all_test_methods branch December 3, 2020 07:30
fabianlinz added a commit to fabianlinz/serenity-junit5 that referenced this pull request Dec 8, 2020
@fabianlinz
Support Serenity annotations on non-public test method (@title, @With…
8655a01 
…Tag) #21

* upgrade to Serenity 2.3.9
  * Consider annotations on non-public test methods (TestAnnotations)
    * serenity-bdd/serenity-core#2306
  * Ignore stacktrace element for inner interfaces and inner or anonymous classes without a superclass (#2229) #2295
    * serenity-bdd/serenity-core#2295
    * >> removed previously added workaround
@fabianlinz fabianlinz mentioned this pull request Dec 8, 2020
Merged
fabianlinz added a commit to fabianlinz/serenity-junit5 that referenced this pull request Dec 8, 2020
@fabianlinz
Support Serenity annotations on non-public test method (@title, @With…
9f0cb90 
…Tag) #21

* upgrade to Serenity 2.3.9
  * Consider annotations on non-public test methods (TestAnnotations)
    * serenity-bdd/serenity-core#2306
  * Ignore stacktrace element for inner interfaces and inner or anonymous classes without a superclass (#2229) #2295
    * serenity-bdd/serenity-core#2295
    * >> removed previously added workaround
fabianlinz added a commit to fabianlinz/serenity-junit5 that referenced this pull request Dec 8, 2020
@fabianlinz
Support Serenity annotations on non-public test method (@title, @With…
3c6861e 
…Tag) #21

* upgrade to Serenity 2.3.9
  * Consider annotations on non-public test methods (TestAnnotations)
    * serenity-bdd/serenity-core#2306
  * Ignore stacktrace element for inner interfaces and inner or anonymous classes without a superclass (#2229) #2295
    * serenity-bdd/serenity-core#2295
    * >> removed previously added workaround
fabianlinz added a commit to fabianlinz/serenity-junit5 that referenced this pull request Dec 8, 2020
@fabianlinz
Support Serenity annotations on non-public test method (@title, @With…
223694f 
…Tag) #21

* upgrade to Serenity 2.3.9
  * Consider annotations on non-public test methods (TestAnnotations)
    * serenity-bdd/serenity-core#2306
  * Ignore stacktrace element for inner interfaces and inner or anonymous classes without a superclass (#2229) #2295
    * serenity-bdd/serenity-core#2295
    * >> removed previously added workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabianlinz @wakaleo