Fixed Test Failure stacktrace, now it can contain elements with no fileName (default.ftl), for #312 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakaleo
added a commit
that referenced
this pull request
Feb 18, 2016
#312 On Test Failure stacktrace can contain elements with no fileName (default.ftl)
|
This looks fine, I'll incorporate it into the next release. thanks for your contribution! |
YamStranger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this PR
Adds a default empty string "" into default.ftl template file to avoid crashing when a fileName is not provided for a function within the error stacktrace.
Adds a newline br tag into the stacktrace dialog, till now there were occasions where multiple functions fit on a single line.
Intended effect
Should prevent failure when a call in the stacktrace does not have an associated fileName.
How should this be manually tested?
Recreate an identical stack to #312.
Side effects
No.
Documentation
Not user facing and no new behavior.
Relevant tickets
#312
Screenshots (if appropriate)
Before:
After:
Error:
