Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Serenity BDD CLI to version >= version 4.x when available #1147

Closed
viper3400 opened this issue Mar 16, 2022 · 4 comments · Fixed by #2103
Closed

Update Serenity BDD CLI to version >= version 4.x when available #1147

viper3400 opened this issue Mar 16, 2022 · 4 comments · Fixed by #2103
Assignees
Labels
enhancement A good idea that should be implemented @serenity-js/serenity-bdd Serenity BDD reporter for Serenity/JS

Comments

@viper3400
Copy link
Sponsor Collaborator

Serenity BDD CLI should be updated to the latest version >= 3.2.0.

There was an attempt in #1129 but there was a regression in 3.1.1 (see #1133) and downgrade to 3.1.0 was necessary. Update to version > 3.1.0 is blocked by serenity-bdd/serenity-core#2721.

@viper3400
Copy link
Sponsor Collaborator Author

Retest today with Serenity BDD CLI v 3.2.5, issue is not solved.

@jan-molak
Copy link
Member

jan-molak commented Jul 31, 2023

We should re-test with Serenity BDD 3.9.8, which has a new requirements parser that might address serenity-bdd/serenity-core#3124

We should also check if this latest version addresses serenity-bdd/serenity-core#3203

Serenity BDD 3.9.8 also uses a different path format in the reports, as per the attachment:
todomvc-test-outcomes.zip

{
  "name": "should_be_able_to_add_the_first_todo_item_with_page_objects",
  "id": "net.serenitybdd.demos.todos.pageobjects.record_todos.AddNewTodos:should_be_able_to_add_the_first_todo_item_with_page_objects",
  "scenarioId": "net.serenitybdd.demos.todos.pageobjects.record_todos.AddNewTodos:should_be_able_to_add_the_first_todo_item_with_page_objects",
  "testCaseName": "net.serenitybdd.demos.todos.pageobjects.record_todos.AddNewTodos",
  "methodName": "should_be_able_to_add_the_first_todo_item_with_page_objects",
  "testSteps": [
    {
      "number": 1,
      "description": "Starts with an empty todo list",
      "duration": 1820,
      "startTime": "2023-07-31T18:37:48.797863+01:00[Europe/London]",
      "result": "SUCCESS",
      "precondition": false,
      "level": 0,
      "children": [
        {
          "number": 2,
          "description": "Starts with a todo list containing: {}",
          "duration": 435,
          "startTime": "2023-07-31T18:37:50.182050+01:00[Europe/London]",
          "result": "SUCCESS",
          "precondition": false,
          "level": 1,
          "children": [
            {
              "number": 3,
              "description": "Adds todo items called: {}",
              "duration": 1,
              "startTime": "2023-07-31T18:37:50.615975+01:00[Europe/London]",
              "result": "SUCCESS",
              "precondition": false,
              "level": 2
            }
          ]
        }
      ]
    },
    {
      "number": 4,
      "description": "Adds a todo item called: Buy some milk",
      "duration": 124,
      "startTime": "2023-07-31T18:37:50.618516+01:00[Europe/London]",
      "result": "SUCCESS",
      "precondition": false,
      "level": 0
    },
    {
      "number": 5,
      "description": "Should see that displayed items contain: {Buy some milk}",
      "duration": 16,
      "startTime": "2023-07-31T18:37:50.743867+01:00[Europe/London]",
      "result": "SUCCESS",
      "precondition": false,
      "level": 0
    }
  ],
  "userStory": {
    "id": "net.serenitybdd.demos.todos.pageobjects.record_todos.AddNewTodos",
    "storyName": "AddNewTodos",
    "displayName": "AddNewTodos",
    "storyClassName": "net.serenitybdd.demos.todos.pageobjects.record_todos.AddNewTodos",
    "path": "pageobjects.record_todos.AddNewTodos",
    "pathElements": [
      {
        "name": "pageobjects",
        "description": "pageobjects"
      },
      {
        "name": "record_todos",
        "description": "record_todos"
      },
      {
        "name": "AddNewTodos",
        "description": "AddNewTodos"
      }
    ],
    "narrative": "",
    "type": "feature"
  },
  "title": "Test to resolve issue #616172",
  "coreIssues": [
    "#616172"
  ],
  "tags": [
    {
      "name": "Chrome",
      "type": "context",
      "displayName": "Chrome"
    },
    {
      "name": "Mac",
      "type": "context",
      "displayName": "Mac"
    },
    {
      "name": "Chrome, Mac",
      "type": "context",
      "displayName": "Chrome, Mac"
    }
  ],
  "startTime": "2023-07-31T18:37:48.779263+01:00[Europe/London]",
  "duration": 1980,
  "projectKey": "",
  "sessionId": "d725086643db2986625aa48ebc1d7dd2",
  "driver": "chrome",
  "isManualTestingUpToDate": false,
  "context": "chrome,mac",
  "manual": false,
  "testSource": "JUnit",
  "order": 0,
  "result": "SUCCESS",
  "issues": [
    "#616172"
  ]
}

@jan-molak jan-molak changed the title Update Serenity BDD CLI to version >= version 3.2.0 Update Serenity BDD CLI to version >= version 3.9.8 Jul 31, 2023
@jan-molak
Copy link
Member

jan-molak commented Aug 5, 2023

Blocked by serenity-bdd/serenity-core#3214

We should upgrade to Serenity BDD CLI 4.x when it becomes available

@jan-molak jan-molak changed the title Update Serenity BDD CLI to version >= version 3.9.8 Update Serenity BDD CLI to version >= version 4.x when available Aug 5, 2023
@jan-molak
Copy link
Member

Adding Serenity BDD 4.0.19 JSON output for reference
screenplay-tests.zip

jan-molak added a commit that referenced this issue Jan 8, 2024
jan-molak added a commit that referenced this issue Jan 9, 2024
… their factory functions

This change enables SerenityBDDReporter to offer a parameterised factory function

re #1147
@jan-molak jan-molak self-assigned this Jan 10, 2024
jan-molak added a commit that referenced this issue Jan 10, 2024
…e SerenityBDDReporter

using the builder pattern instead of the no-arg constructor

Related tickets: re #1147
jan-molak added a commit that referenced this issue Jan 10, 2024
jan-molak added a commit that referenced this issue Jan 10, 2024
@jan-molak jan-molak removed the blocked label Jan 10, 2024
jan-molak added a commit that referenced this issue Jan 10, 2024
jan-molak added a commit that referenced this issue Jan 11, 2024
when calling serenity-bdd run

Related tickets: re #1147
jan-molak added a commit that referenced this issue Jan 11, 2024
jan-molak added a commit that referenced this issue Jan 11, 2024
jan-molak added a commit that referenced this issue Jan 12, 2024
jan-molak added a commit that referenced this issue Jan 14, 2024
…sing Serenity BDD reporter

Related tickets: re #1147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A good idea that should be implemented @serenity-js/serenity-bdd Serenity BDD reporter for Serenity/JS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants