Implement suggestions from clippy & remove clippy arg max config (#595)

serenity-rs · Jun 3, 2019 · 6586830 · 6586830
1 parent ddf7a3f
commit 6586830
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 15 deletions.
diff --git a/clippy.toml b/clippy.toml
@@ -5,4 +5,3 @@ doc-valid-idents = [
 ]
 enum-variant-name-threshold = 1
 single-char-binding-names-threshold = 3
-too-many-arguments-threshold = 6
diff --git a/src/framework/standard/help_commands.rs b/src/framework/standard/help_commands.rs
@@ -736,20 +736,20 @@ pub fn searched_lowercase<'a>(
         )
     };
     let mut progressed = is_prefixless_group;
+    let is_word_prefix = group
+        .options
+        .prefixes
+        .iter()
+        .any(|prefix| {
+            if starts_with_whole_word(&searched_named_lowercase, &prefix) {
+                searched_named_lowercase.drain(..=prefix.len());
+                progressed = true;
+            }
 
-    if is_prefixless_group
-        || group
-            .options
-            .prefixes
-            .iter()
-            .any(|prefix| {
-                if starts_with_whole_word(&searched_named_lowercase, &prefix) {
-                    searched_named_lowercase.drain(..=prefix.len());
-                    progressed = true;
-                }
+            prefix == searched_named_lowercase
+        });
 
-                prefix == &searched_named_lowercase
-            })
+    if is_prefixless_group || is_word_prefix
     {
         let single_group =
             create_single_group(&context, &group, owners, &msg, &help_options);

diff --git a/src/model/channel/guild_channel.rs b/src/model/channel/guild_channel.rs
@@ -730,8 +730,7 @@ impl GuildChannel {
                 .voice_states
                 .values()
                 .filter_map(|v| {
-                    v.channel_id.map_or(
-                        None,
+                    v.channel_id.and_then(
                         |c| {
                             if c == self.id {
                                 guild.read().members.get(&v.user_id).cloned()