Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice receive not initially working after connecting to voice channel #301

Closed
Sunspar opened this issue Apr 11, 2018 · 0 comments
Closed
Labels
bug Something misbehaves or is not working. discord feature Related to Discord's functionality.

Comments

@Sunspar
Copy link

Sunspar commented Apr 11, 2018

With the latest master (a6eda12 at the time of writing) voice receive appears to be wonky — the example 10_voice_receive doesn’t work as advertised.

We narrowed it down to an issue with discord and how they appear to handle (or not handle) initialization of voice connections. Essentially an implementation of AudioReceivers speaking_update will fire if you add print statements or other work to it, but the voice_packet function doesn’t seem to do anything.

The workaround that was figured out for now is to send audio using the bot on connection to a voice channel; after that, incoming packets seem to log as you’d expect.

It sounds like JDA has a similar bug logged so I don’t think it’s necessarily a serenity thing, but we may want an answer for this, even if it’s just “This is known, send a packet first”.

@arqunis arqunis added bug Something misbehaves or is not working. discord feature Related to Discord's functionality. labels Apr 11, 2018
FelixMcFelix added a commit to FelixMcFelix/serenity that referenced this issue Apr 13, 2018
* Sends 100 empty frames at discord upon connection.
* Moves silent frame def out into the constants file (named).
@ghost ghost closed this as completed in 83a0c85 Apr 20, 2018
ghost pushed a commit that referenced this issue Aug 12, 2018
This reverts commit 83a0c85.

This makes voice sending work again.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something misbehaves or is not working. discord feature Related to Discord's functionality.
Projects
None yet
Development

No branches or pull requests

2 participants