Support components (buttons and dropdowns) #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Milo123459
reviewed
May 30, 2021
Co-authored-by: Milo <50248166+Milo123459@users.noreply.github.com>
arqunis
added
enhancement
arqunis
added
client
|
maybe add an example on how to use them with serenity? Would help new discord bot devs |
drklee3
reviewed
Jun 2, 2021
drklee3
reviewed
Jun 2, 2021
Co-authored-by: Derrick Lee <github@dlee.dev>
arqunis
pushed a commit
that referenced
this pull request
Jun 3, 2021
This removes the early return when handling `reaction_filters` on a non-reaction event. This fixes collector filters that may run after the reaction filter but are incorrectly skipped, such as in #1369. If using component interaction filters and there are existing reaction filters, it will return early on `Interaction Create` events and skip handling the corresponding component interaction filters.
arqunis
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to components, as per discord/discord-api-docs#3007 (see https://discord.com/developers/docs/interactions/message-components).
Others relevant PRs: discord/discord-api-docs#3012, discord/discord-api-docs@06218a9
This PR also adds support to dropdowns. There is no official public documentation currently, I implemented it thanks to discordjs/discord.js#5692.
This PR is the continuation of #1364
This has been tested.