Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented #[required_permissions(perms)] requirements #1479

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Undocumented #[required_permissions(perms)] requirements #1479

merged 2 commits into from
Aug 29, 2021

Conversation

woongzeyi
Copy link
Contributor

Ever since intents became mandatory, developers have been needed to add required intents while building client when using #[required_permissions(perms)] attribute from group and command macro, which is never documented.
I fixed the misleading command framework example and added requirement docs to the macro attribute, which should help fixing this issue.

…ons(perms)]` requirement docs

Co-Authored-By: Victoria Casasampere Fernandez <vickyf5124@gmail.com>
Co-Authored-By: Splingush <9380654+Splingush@users.noreply.github.com>
@woongzeyi woongzeyi changed the title Fix misleading command framework example and add #[required_permissions(perms)] requirement docs Undocumented #[required_permissions(perms)] requirements Aug 27, 2021
command_attr/src/lib.rs Outdated Show resolved Hide resolved
command_attr/src/lib.rs Outdated Show resolved Hide resolved
examples/e05_command_framework/src/main.rs Outdated Show resolved Hide resolved
@arqunis arqunis added docs Related to documentation. enhancement An improvement to Serenity. examples Related to Serenity's examples. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate labels Aug 27, 2021
Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
@woongzeyi woongzeyi requested a review from arqunis August 28, 2021 05:34
@Flat Flat merged commit f9de6c5 into serenity-rs:current Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to documentation. enhancement An improvement to Serenity. examples Related to Serenity's examples. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants