Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace json::from_number with into() #2034

Merged
merged 1 commit into from Jul 3, 2022
Merged

Replace json::from_number with into() #2034

merged 1 commit into from Jul 3, 2022

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Jul 2, 2022

Both Value types implement From for their number variants.

@nickelc
Replace json::from_number with into()
b2b1837 
Both `Value` types implement `From` for their number variants.
@nickelc nickelc added the enhancement An improvement to Serenity. label Jul 2, 2022
@github-actions github-actions bot added http Related to the `http` module. model Related to the `model` module. labels Jul 2, 2022
@nickelc nickelc merged commit 9ab0855 into serenity-rs:next Jul 3, 2022
@nickelc nickelc deleted the remove_from_number branch July 3, 2022 18:49
nickelc added a commit to nickelc/serenity that referenced this pull request Jul 4, 2022
@nickelc
Replace json::from_number with into() (serenity-rs#2034)
753c849 
Both `Value` types implement `From` for their number variants.
nickelc added a commit to nickelc/serenity that referenced this pull request Jul 4, 2022
@nickelc
Replace json::from_number with into() (serenity-rs#2034)
1a1dd36 
Both `Value` types implement `From` for their number variants.
@nickelc nickelc added the breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users label Jul 5, 2022
@nickelc
Copy link
Contributor Author

nickelc commented Jul 5, 2022

This is technically a breaking change because the ToNumber trait was public.

arqunis pushed a commit to arqunis/serenity that referenced this pull request Jul 20, 2022
@nickelc @arqunis
Replace json::from_number with into() (serenity-rs#2034)
28bb029 
Both `Value` types implement `From` for their number variants.
arqunis pushed a commit that referenced this pull request Aug 21, 2022
@nickelc @arqunis
Replace json::from_number with into() (#2034)
f0974f8 
Both `Value` types implement `From` for their number variants.
arqunis pushed a commit that referenced this pull request Sep 2, 2022
@nickelc @arqunis
Replace json::from_number with into() (#2034)
cd91ecb 
Both `Value` types implement `From` for their number variants.
kangalio pushed a commit to kangalio/serenity that referenced this pull request Sep 11, 2022
@nickelc @kangalio
Replace json::from_number with into() (serenity-rs#2034)
c6c09ef 
Both `Value` types implement `From` for their number variants.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 1, 2022
@nickelc @mkrasnitski
Replace json::from_number with into() (serenity-rs#2034)
329a30e 
Both `Value` types implement `From` for their number variants.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Nov 7, 2022
@nickelc @mkrasnitski
Replace json::from_number with into() (serenity-rs#2034)
f401836 
Both `Value` types implement `From` for their number variants.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 13, 2022
@nickelc @arqunis
Replace json::from_number with into() (serenity-rs#2034)
8da2f76 
Both `Value` types implement `From` for their number variants.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 28, 2023
@nickelc @mkrasnitski
Replace json::from_number with into() (serenity-rs#2034)
966b6af 
Both `Value` types implement `From` for their number variants.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
@nickelc @mkrasnitski
Replace json::from_number with into() (serenity-rs#2034)
aba8139 
Both `Value` types implement `From` for their number variants.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
@nickelc @mkrasnitski
Replace json::from_number with into() (serenity-rs#2034)
659de9a 
Both `Value` types implement `From` for their number variants.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@nickelc @mkrasnitski
Replace json::from_number with into() (serenity-rs#2034)
7405069 
Both `Value` types implement `From` for their number variants.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@nickelc @mkrasnitski
Replace json::from_number with into() (serenity-rs#2034)
895146d 
Both `Value` types implement `From` for their number variants.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@nickelc @mkrasnitski
Replace json::from_number with into() (serenity-rs#2034)
dcd7137 
Both `Value` types implement `From` for their number variants.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@nickelc @arqunis
Replace json::from_number with into() (serenity-rs#2034)
d0cc6cd 
Both `Value` types implement `From` for their number variants.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@nickelc @arqunis
Replace json::from_number with into() (serenity-rs#2034)
3e2d310 
Both `Value` types implement `From` for their number variants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nickelc