Add cached messages to channel_delete event handler #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails if the cache is disabled. The code should only get the messages from cache if it is enabled. For consistency, this should happen in the CacheUpdate implementation for ChannelDeleteEvent, like already done for member/guild/role/thread deletes. That also takes care of only running the code when cache is enabled |
|
I'm confused, do I have to do something or is this alright now? |
|
You'll have to rebase your PR on top of next. I recommend doing |
github-actions
bot
removed
cache
github-actions
bot
added
cache
mkrasnitski
reviewed
Oct 2, 2022
Co-authored-by: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
kangalio
approved these changes
Oct 2, 2022
|
I always forget to format with nightly haha |
arqunis
requested changes
Oct 2, 2022
Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
arqunis
approved these changes
Oct 2, 2022
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Nov 7, 2022
arqunis
pushed a commit
that referenced
this pull request
Nov 13, 2022
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 28, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reason I'm making this PR is issue #2180
If there is a better way to do this I'd be happy to implement that instead (especially if it doesn't introduce a breaking change).
Updating the cache after the event is handled is not possible without having to clone
event.channelwhich I didn't wanna do.Closes #2180