Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all model types #[non_exhaustive] where it makes sense #2397

Merged
merged 2 commits into from Apr 25, 2023
Merged

Make all model types #[non_exhaustive] where it makes sense #2397

merged 2 commits into from Apr 25, 2023

Conversation

kangalio
Copy link
Collaborator

@kangalio kangalio commented Apr 22, 2023 •
edited

To ensure forward-compatibility - when Discord adds new fields, we don't want to have to make a breaking release

@github-actions github-actions bot added the model Related to the `model` module. label Apr 22, 2023
@github-actions github-actions bot added the utils Related to the `utils` module. label Apr 22, 2023
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Apr 25, 2023
@arqunis arqunis merged commit fb72ec2 into serenity-rs:next Apr 25, 2023
21 checks passed
@kangalio kangalio mentioned this pull request Apr 26, 2023
Merged
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
@kangalio @mkrasnitski
Make all model types #[non_exhaustive] where it makes sense (sereni…
40c2b36 
…ty-rs#2397)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 19, 2023
@kangalio @mkrasnitski
Make all model types #[non_exhaustive] where it makes sense (sereni…
e1a0226 
…ty-rs#2397)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
@kangalio @mkrasnitski
Make all model types #[non_exhaustive] where it makes sense (sereni…
a603578 
…ty-rs#2397)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@kangalio @mkrasnitski
Make all model types #[non_exhaustive] where it makes sense (sereni…
5c11bfd 
…ty-rs#2397)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@kangalio @mkrasnitski
Make all model types #[non_exhaustive] where it makes sense (sereni…
9c175cd 
…ty-rs#2397)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@kangalio @mkrasnitski
Make all model types #[non_exhaustive] where it makes sense (sereni…
c86d500 
…ty-rs#2397)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@kangalio @arqunis
Make all model types #[non_exhaustive] where it makes sense (sereni…
08509b6 
…ty-rs#2397)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@kangalio @arqunis
Make all model types #[non_exhaustive] where it makes sense (sereni…
ec44ab5 
…ty-rs#2397)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kangalio @arqunis