Make discriminator optional and non-zero in preparation for new usernames #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cache
|
Breaking changes should target |
|
Alright, let me get these conflicts sorted |
Xaeroxe
force-pushed
the
discriminator-optional
branch
3 times, most recently
from
edce406
to
c15b051
Compare
|
This is ready for review now. I was winging it and I didn't do much in the way of consulting people about API design here. I recognize this is not good practice and I apologize. |
Xaeroxe
force-pushed
the
discriminator-optional
branch
2 times, most recently
from
0c8e10d
to
9b4cfa5
Compare
|
Formatting wasn't correct because I didn't invoke it properly before. It's fixed now. |
Xaeroxe
force-pushed
the
discriminator-optional
branch
from
9b4cfa5
to
cd50b77
Compare
arqunis
added
enhancement
arqunis
approved these changes
May 6, 2023
|
Thanks! |
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 7, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 17, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 17, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 19, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 21, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 3, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 26, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Aug 28, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 6, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 23, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Nov 1, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires a major version bump!
Per https://discord.com/blog/usernames the discriminator field is about to become optional. This will proceed in two phases. It's not clear when phase 1 will start. It may have started already.
Phase 0 (Prior behavior): All users have discriminators.
Phase 1: Users with discriminators co-exist among users without discriminators. Users without discriminators have
"discriminator": 0in their JSON during this phase.Phase 2: Once all users are migrated, discriminators are eliminated entirely and won't be returned in the JSON.
This PR is designed such that it can continue working correctly regardless of which phase we are currently in.