Added additional reaction controls to channel_id and message structs #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrasnitski
requested changes
Sep 6, 2023
src/model/channel/channel_id.rs
Outdated
Comment on lines
282
to
286
| /// Deletes all of the [`Reaction`]s associated with the provided message id. | ||
| /// | ||
| /// **Note**: Requires the [Manage Messages] permission. | ||
| /// | ||
| /// [Manage Messages]: Permissions::MANAGE_MESSAGES |
There was a problem hiding this comment.
Should include an # Errors section.
src/model/channel/message.rs
Outdated
Comment on lines
285
to
294
| cache_http | ||
| .http() | ||
| .as_ref() | ||
| .delete_reaction( | ||
| self.channel_id.0, | ||
| self.id.0, | ||
| user_id.map(|uid| uid.0), | ||
| &reaction_type.into(), | ||
| ) | ||
| .await |
There was a problem hiding this comment.
This should be reworked to just a wrapper around ChannelId::delete_reaction. The same goes for Message::delete_reactions, now that ChannelId::delete_reactions exists.
src/model/channel/message.rs
Outdated
Comment on lines
274
to
275
| /// Returns [`Error::Http`] if the currend user did not perform the reaction, | ||
| /// and lacks permission |
There was a problem hiding this comment.
Suggested change
| /// Returns [`Error::Http`] if the currend user did not perform the reaction, | |
| /// and lacks permission | |
| /// Returns [`Error::Http`] if the current user did not perform the reaction, or lacks | |
| /// permission. |
formatting
Co-authored-by: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
mkrasnitski
requested changes
Sep 7, 2023
Co-authored-by: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Co-authored-by: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
mkrasnitski
approved these changes
Sep 9, 2023
arqunis
approved these changes
Sep 9, 2023
|
This slipped past in review, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2532 In reference to this issue.