Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated types for GuildId::audit_logs #2623

Merged
merged 1 commit into from Nov 26, 2023
Merged

Use dedicated types for GuildId::audit_logs #2623

merged 1 commit into from Nov 26, 2023

Conversation

GnomedDev
Copy link
Member

Fixes #2488

@github-actions github-actions bot added model Related to the `model` module. http Related to the `http` module. labels Nov 24, 2023
mkrasnitski
mkrasnitski approved these changes Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@mkrasnitski mkrasnitski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change I'd suggest would be to import audit_log::Action.

@GnomedDev
Copy link
Member Author

We have other types called Action in the library, so that would be ambiguous, I'm usually quite happy to import stuff.

@arqunis arqunis added the fix A solution to an existing bug. label Nov 26, 2023
@arqunis arqunis merged commit bc2a5b5 into serenity-rs:current Nov 26, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkrasnitski mkrasnitski mkrasnitski approved these changes

Assignees
No one assigned
Labels
fix A solution to an existing bug. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Partial)Guild(Id)::audit_logs takes in raw action type IDs instead of the Action enum
3 participants
@GnomedDev @mkrasnitski @arqunis