Fix FixedString<u8> truncation when multibyte characters push over the limit #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
added
fix
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Dec 28, 2023
…s push over the limit (serenity-rs#2660)
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 2, 2024
…s push over the limit (serenity-rs#2660)
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 5, 2024
…s push over the limit (serenity-rs#2660)
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 16, 2024
…s push over the limit (serenity-rs#2660)
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 22, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
that referenced
this pull request
Feb 9, 2024
…s push over the limit (#2660)
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Mar 1, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
that referenced
this pull request
Mar 10, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
that referenced
this pull request
Mar 11, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
that referenced
this pull request
Mar 11, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 13, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
that referenced
this pull request
Mar 13, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 19, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 19, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
that referenced
this pull request
Mar 21, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
that referenced
this pull request
Mar 25, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
that referenced
this pull request
Mar 29, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
that referenced
this pull request
Mar 31, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 31, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Apr 1, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
May 14, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
that referenced
this pull request
May 14, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
that referenced
this pull request
May 23, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
that referenced
this pull request
May 28, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 9, 2024
…s push over the limit (serenity-rs#2660)
GnomedDev
added a commit
that referenced
this pull request
Jun 22, 2024
…s push over the limit (#2660)
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 22, 2024
…s push over the limit (serenity-rs#2660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused an issue where one GuildChannel had a name over 255 bytes, but under 100 characters, so I did another pass over and increased lengths when needed. In practice without this the only problem is an annoying
errorlog and the name being truncated, but good to fix anyway.