Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove impl Into<Option> #2701

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Remove impl Into<Option> #2701

merged 1 commit into from
Jan 10, 2024

Conversation

GnomedDev
Copy link
Member

This signature is hard to use as None cannot infer the type of the generic. I also replaced Option<u8> with Option<NonMaxU8> as it's more efficient and will make the user think of the maximum value.

@github-actions github-actions bot added model Related to the `model` module. http Related to the `http` module. labels Jan 9, 2024
@github-actions github-actions bot added the builder Related to the `builder` module. label Jan 9, 2024
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jan 10, 2024
@arqunis arqunis merged commit cb7b95f into serenity-rs:next Jan 10, 2024
22 checks passed
@GnomedDev GnomedDev deleted the no-into-opt branch January 10, 2024 21:43
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2024
@GnomedDev @arqunis
Remove impl Into<Option> (serenity-rs#2701)
8ddd656 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@GnomedDev @arqunis
Remove impl Into<Option> (serenity-rs#2701)
93caec3 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
6dec333 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
arqunis pushed a commit that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Remove impl Into<Option> (#2701)
1dcab5e 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
be33f08 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
e2d1590 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
1488b13 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Remove impl Into<Option> (serenity-rs#2701)
d416247 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
392c94c 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove impl Into<Option> (serenity-rs#2701)
1e4e397 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove impl Into<Option> (serenity-rs#2701)
8c06a43 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
5a5c9a9 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
7636d6c 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
a64e4c0 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
0c5dbaf 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Remove impl Into<Option> (serenity-rs#2701)
9a1103d 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Remove impl Into<Option> (serenity-rs#2701)
6fdfa5d 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Remove impl Into<Option> (serenity-rs#2701)
cf36ace 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
bcccf95 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
714806f 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
c3c68ae 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Remove impl Into<Option> (serenity-rs#2701)
a99e06b 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Remove impl Into<Option> (#2701)
2263a9a 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Remove impl Into<Option> (serenity-rs#2701)
5c704dc 
This signature is hard to use as `None` cannot infer the type of the
generic. I also replaced `Option<u8>` with `Option<NonMaxU8>` as it's
more efficient and will make the user think of the maximum value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. enhancement An improvement to Serenity. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GnomedDev @arqunis