Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CreateAttachment::id field #2771

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Remove CreateAttachment::id field #2771

merged 1 commit into from
Feb 17, 2024

Conversation

mkrasnitski
Copy link
Collaborator

For new attachments, the value of the id field corresponds to their order in the payload. Because these ids are sequential, we can simply calculate them when forming the multipart payload/serializing.

cc @kangalio

@github-actions github-actions bot added builder Related to the `builder` module. http Related to the `http` module. labels Feb 16, 2024
GnomedDev
GnomedDev requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small improvement before I can approve

src/builder/create_attachment.rs Show resolved Hide resolved
@GnomedDev GnomedDev merged commit be431cf into serenity-rs:next Feb 17, 2024
21 checks passed
@mkrasnitski mkrasnitski deleted the attachment-id branch February 17, 2024 02:18
arqunis pushed a commit that referenced this pull request Mar 1, 2024
@mkrasnitski @arqunis
Remove CreateAttachment::id field (#2771)
d08bfaa
GnomedDev pushed a commit that referenced this pull request Mar 10, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
932e2e5
GnomedDev pushed a commit that referenced this pull request Mar 11, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
6a9e9ea
GnomedDev pushed a commit that referenced this pull request Mar 11, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
ea0285d
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (serenity-rs#2771)
dc18401
GnomedDev pushed a commit that referenced this pull request Mar 13, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
3d174e6
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (serenity-rs#2771)
a6673e8
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (serenity-rs#2771)
bfcd5f0
GnomedDev pushed a commit that referenced this pull request Mar 21, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
99bea8f
GnomedDev pushed a commit that referenced this pull request Mar 25, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
bb0fddc
GnomedDev pushed a commit that referenced this pull request Mar 25, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
18bbef6
GnomedDev pushed a commit that referenced this pull request Mar 29, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
6fdb666
GnomedDev pushed a commit that referenced this pull request Mar 31, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
5e5cea0
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (serenity-rs#2771)
3e23c13
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (serenity-rs#2771)
af929e5
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (serenity-rs#2771)
84b844d
GnomedDev pushed a commit that referenced this pull request May 14, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
e902b6b
GnomedDev pushed a commit that referenced this pull request May 23, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
47585b0
GnomedDev pushed a commit that referenced this pull request May 28, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
e28d2ae
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (serenity-rs#2771)
a9b4ebf
GnomedDev pushed a commit that referenced this pull request Jun 22, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (#2771)
983c28a
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@mkrasnitski @GnomedDev
Remove CreateAttachment::id field (serenity-rs#2771)
5e30e0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnomedDev GnomedDev GnomedDev approved these changes

Assignees
No one assigned
Labels
builder Related to the `builder` module. http Related to the `http` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkrasnitski @GnomedDev