Deprecate Cache methods returning mapped references #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
GnomedDev
force-pushed
the
deprecate-cache-mapped-ref
branch
from
f6f8f1a
to
69fd670
Compare
github-actions
bot
added
the
framework
GnomedDev
force-pushed
the
deprecate-cache-mapped-ref
branch
2 times, most recently
from
ff51827
to
4ee8e15
Compare
GnomedDev
force-pushed
the
deprecate-cache-mapped-ref
branch
2 times, most recently
from
9c0e50e
to
d4efb09
Compare
arqunis
approved these changes
Mar 13, 2024
arqunis
pushed a commit
that referenced
this pull request
Mar 16, 2024
This was mistakenly removed in #2794 but is still possible here as we have the `GuildId`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mapped references confuse beginners to the simplicity of the cache, and can lead to performance hits for users who accidentally fetch guilds multiple times in one function. It also leads to extra caching when absolutely optional, such as the
Cache::channelscache which simply storesChannelId: GuildIdfor the methods which need aGuildIdbut don't take it. This PR deprecates the methods and removes the usage when possible, and if not deprecates the methods it was used on.I have had to remove some of the preemptive error checks or move them to the model versions instead of the ID versions, but I don't exactly like these preemptive checks anyway.