Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples and inaccurate docs from HTTP #2805

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

GnomedDev
Copy link
Member

Http is a low level interface and contained a lot of outdated/inaccurate documentation and completely useless examples that just showed how to call a function in rust. This removes them which makes splitting http out a lot easier.

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. http Related to the `http` module. labels Mar 17, 2024
@arqunis arqunis added enhancement An improvement to Serenity. docs Related to documentation. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Mar 17, 2024
@GnomedDev GnomedDev merged commit 23a2f96 into serenity-rs:next Mar 17, 2024
21 checks passed
@GnomedDev GnomedDev deleted the remove-httpexamples branch March 17, 2024 23:43
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. docs Related to documentation. enhancement An improvement to Serenity. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants